[Freeciv-Dev] Re: (PR#13474) a city_production struct

["Benoit Hudson" <benoit.hudson@xxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13474 >

> Wastes less memory, makes it more obvious there can only be one item at a
> time, etc.

where "etc" maps to "more likely to call unit_type functions on a
impr_type and crash in mysterious ways.  Unions are dangerous; unless
we're extremely pinched on space (which for city structs we aren't)
they are to be avoided.

Of course, currently we're likely to occasionally use an
improvement-type index as a unit-type.