[Freeciv-Dev] (PR#13458) horrendous buffer underflows in mapgen.c

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13458 >

After doing some testing I don't believe this is a problem in 2.0.  I
don't know why exactly, but it must have been introduced by my
gen-terrain changes to mapgen that have happened since 2.0.  And since
this has been fixed/exposed in the development version I am closing this
bug.

However dereferencing of T_UNKNOWN is still a potential problem.  Now
that terrains are done by pointer this will cause a crash rather than a
buffer underflow, so any such bugs should now be easily fixable once we
find them.  A full audit of mapgen might be appropriate at some point
but this is a daunting task.

-jason