Complete.Org: Mailing Lists: Archives: freeciv-dev: July 2005:
[Freeciv-Dev] Re: (PR#13416) 64bit glitch
Home

[Freeciv-Dev] Re: (PR#13416) 64bit glitch

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: macallan@xxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#13416) 64bit glitch
From: "Benoit Hudson" <bh@xxxxxxxxxxxxxxxxxxx>
Date: Thu, 7 Jul 2005 21:08:28 -0700
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13416 >

On Thu, Jul 07, 2005 at 09:02:50PM -0700, Jason Short wrote:
> Oh my.  This entire file is evil.

No disagreements there.

> But this patch should fix that code.  Maybe.  I agree a uint64 would be
> better here.  The patch is for 2.0 (maybe the asserts should be left
> out) but should be applied to the dev branch as well, of course.

Why not use the <stdint.h> required by C99 ?  Then we can use uint8_t and
so on, and ditch the assertions which would only fail if the compiler were
non-compliant.

        -- Benoît





[Prev in Thread] Current Thread [Next in Thread]