[Freeciv-Dev] Re: (PR#13355) Percent defense bonus

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13355 >

James Canete wrote:

> This patch compiles, but has not yet been tested.

The combat.c parts look wrong:


-  db = get_tile_type(t)->defense_bonus;
+  db = 10 + get_tile_type(t)->defense_bonus / 10;

this should be 100 right?

Also, if it does stay as a multiplier it should be called
defense_multiplier not defense_bonus.

Finally, the whole thing could be done with effects.  It would be much
slower though.

-jason