[Freeciv-Dev] (PR#12931) autoexplorers crash in development code

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12931 >

Load the attached savegame, connect, hit turn done.  This is with the
CVS development branch from Fri Apr 29 07:47:28 UTC 2005.

civserver: unittools.c:651: update_unit_activity: Assertion
`punit->activity == ACTIVITY_EXPLORE' failed.

(gdb) bt
#0  0x400b583b in raise () from /lib/tls/libc.so.6
#1  0x400b6fa2 in abort () from /lib/tls/libc.so.6
#2  0x400af2df in __assert_fail () from /lib/tls/libc.so.6
#3  0x0805f747 in update_unit_activity (punit=0x8507a68) at unittools.c:991
#4  0x0805eda8 in update_unit_activities (pplayer=0x81ea150)
    at unittools.c:521
#5  0x080504ad in begin_phase (is_new_phase=true) at srv_main.c:532
#6  0x08052641 in main_loop () at srv_main.c:1553
#7  0x08052deb in srv_loop () at srv_main.c:1941
#8  0x0805291f in srv_main () at srv_main.c:1677
#9  0x0804a749 in main (argc=135526990, argv=0xbffff8f4) at civserver.c:242
(gdb) select 3
(gdb) p punit->activity
$1 = ACTIVITY_IDLE

The ai_manage_explorer function returns with the explorer in an idle
state.  This causes a failed assertion.

-jason