Complete.Org: Mailing Lists: Archives: freeciv-dev: April 2005:
[Freeciv-Dev] Re: (PR#12926) output_type structure
Home

[Freeciv-Dev] Re: (PR#12926) output_type structure

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Subject: [Freeciv-Dev] Re: (PR#12926) output_type structure
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 28 Apr 2005 18:07:56 -0700
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12926 >

Benoit Hudson wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=12926 >
> 
> On Thu, Apr 28, 2005 at 11:38:09AM -0700, Jason Short wrote:
> 
>><URL: http://bugs.freeciv.org/Ticket/Display.html?id=12926 >
>>
>>For further gen-output work we need an output_type structure.  This
>>patch adds it.  It's pretty straightforward.
> 
> Would it be worthwhile to write a code generator to do this kind of
> thing?  We have lots of enums with corresponding get_enum_name functions
> and arrays, every one of them prone to mismatches.

I don't think so, because in most cases the goal is to move the
structure info out into the ruleset.  The statically initialized arrays
are just a temporary measure (at least for the output type; the same was
done for buildings, specialists, terrains, etc.).

-jason





[Prev in Thread] Current Thread [Next in Thread]