Complete.Org: Mailing Lists: Archives: freeciv-dev: April 2005:
[Freeciv-Dev] Re: (PR#12900) pubserver crash in /start 		Home

[Freeciv-Dev] Re: (PR#12900) pubserver crash in /start

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#12900) pubserver crash in /start
From: "Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>
Date: Tue, 26 Apr 2005 10:49:53 -0700
Reply-to: bugs@xxxxxxxxxxx 
<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12900 >

On Tue, Apr 26, 2005 at 10:41:08AM -0700, Jason Short wrote:
> 
> I don't understand.  Detached player have call->player as NULL, right?
> So we have to check this before dereferencing it.  Are you saying
> detached players should not have call->player as NULL?

yes. ok, I misread your patch. It looks ok, but using caller->observer
would be better than caller->player->is_connected.

-mike
[Prev in Thread] Current Thread [Next in Thread]