[Freeciv-Dev] Re: (PR#12900) pubserver crash in /start

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12900 >

Mike Kaufman wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=12900 >
> 
> On Tue, Apr 26, 2005 at 10:23:43AM -0700, Jason Short wrote:
> 
>>>I'm not sure about this patch. If a connection detaches, then call->player
>>>should always be NULL.
>>
>>Exactly.
> 
> then the bug is in detach_command() or most likely
> in unattach_connection_from_player()

I don't understand.  Detached player have call->player as NULL, right?
So we have to check this before dereferencing it.  Are you saying
detached players should not have call->player as NULL?

-jason