[Freeciv-Dev] (PR#12872) Client Factory Help-Text Crash

["Benedict Adamson" <badamson@xxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12872 >

Trying to view the help-text for the Factory improvement causes the 
client to crash.

Gtk2, Debian sarge, Linux 2.6.8-2-k7, gcc 3.3.5 (Debian 1:3.3.5-6).

Here is the trace back:
#0  0x4053a7ab in raise () from /lib/tls/libc.so.6
#1  0x4053bf12 in abort () from /lib/tls/libc.so.6
#2  0x4053426f in __assert_fail () from /lib/tls/libc.so.6
#3  0x080ab7c9 in mystrlcat (dest=0xbffeead0 "", src=0x0, n=512)
     at support.c:275
#4  0x080fec70 in get_req_source_text (psource=0x6, buf=0xbffeead0 "",
     bufsz=512) at requirements.c:806
#5  0x0807c3eb in insert_allows (psource=0xbffeef10, buf=0xbffef1b2 "",
     bufsz=63886) at helpdata.c:236
#6  0x0807d4da in helptext_building (
     buf=0xbffef140 "Increases the shield production in a city by 50%. 
This increase may also contribute significantly to pollution.\n\n", 
bufsz=64000,
     which=11, user_text=0x89304d8 "") at helpdata.c:668
#7  0x0812db60 in help_update_improvement (pitem=0x0,
     title=0x89304c9 "Factory", which=11) at helpdlg.c:715
#8  0x0812f75c in help_update_dialog (pitem=0x89304b8) at helpdlg.c:1157
#9  0x0812c807 in activated_topic (view=0xbfffebb0, data=0x0) at 
helpdlg.c:390
#10 0x404323b6 in g_cclosure_marshal_VOID__VOID ()
    from /usr/lib/libgobject-2.0.so.0
#11 0x404206b6 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#12 0x40431ec8 in g_signal_emit_by_name () from /usr/lib/libgobject-2.0.so.0
#13 0x40430f4c in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
#14 0x404311e6 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
---Type <return> to continue, or q <return> to quit---
#15 0x4021fd28 in gtk_tree_view_set_reorderable ()
    from /usr/lib/libgtk-x11-2.0.so.0
#16 0x40210934 in gtk_tree_view_get_type () from 
/usr/lib/libgtk-x11-2.0.so.0
#17 0x401496de in _gtk_marshal_BOOLEAN__BOXED ()
    from /usr/lib/libgtk-x11-2.0.so.0
#18 0x40420949 in g_cclosure_new_swap () from /usr/lib/libgobject-2.0.so.0
#19 0x404206b6 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#20 0x40431925 in g_signal_emit_by_name () from /usr/lib/libgobject-2.0.so.0
#21 0x40430d3a in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
#22 0x404311e6 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
#23 0x402388a7 in gtk_widget_send_expose () from 
/usr/lib/libgtk-x11-2.0.so.0
#24 0x401481f2 in gtk_propagate_event () from /usr/lib/libgtk-x11-2.0.so.0
#25 0x40147046 in gtk_main_do_event () from /usr/lib/libgtk-x11-2.0.so.0
#26 0x40344815 in _gdk_events_queue () from /usr/lib/libgdk-x11-2.0.so.0
#27 0x404776c2 in g_main_depth () from /usr/lib/libglib-2.0.so.0
#28 0x40478748 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
#29 0x40478a80 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
#30 0x40479023 in g_main_loop_run () from /usr/lib/libglib-2.0.so.0
#31 0x401468f3 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0
#32 0x08128f47 in ui_main (argc=1, argv=0xbffff944) at gui_main.c:1211
#33 0x08070a44 in main (argc=1, argv=0xbffff944) at civclient.c:350