[Freeciv-Dev] Re: (PR#12804) gui-xaw CMA crash PATCH

["Vijay Kiran Kamuju" <infyquest@xxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12804 >

I think that The Code i commented is just below the iterate

XtVaSetValues(stat_factor_label[i], XtNwidth, 90, NULL);
here the i value during the execution takes the value of 7

and I think the there is no info for the Widget stat_factor_label[i]

I have not run the old version when the code used NUM_STATS instead of 
O_COUNT

I dont have the old version source code.

I'll download freeciv 1.14.2 src code and check it there.

On 4/16/05, Jason Short <jdorje@xxxxxxxxxxxxxxxxxxxxx> wrote:
> 
> 
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=12804 >
> 
> 1. It's better to use #if 0...#endif rather than commenting out large
> blocks of code.
> 
> 2. With code like this I'd like to see a comment about why it is
> removed. I don't really understand how this fixes the problem.
> 
> -jason
> 
>

I think that The Code i commented is just below the iterate

XtVaSetValues(stat_factor_label[i], XtNwidth, 90, NULL);
here the i value during the execution takes the value of 7

and I think the there is no info for the Widget stat_factor_label[i]

I have not run the old version when the code used NUM_STATS instead of O_COUNT

I dont have the old version source code.

I'll download freeciv 1.14.2 src code and check it there.

On 4/16/05, Jason Short <jdorje@xxxxxxxxxxxxxxxxxxxxx> wrote:

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12804 >

1.  It's better to use #if 0...#endif rather than commenting out large
blocks of code.

2.  With code like this I'd like to see a comment about why it is
removed.  I don't really understand how this fixes the problem.

-jason