[Freeciv-Dev] (PR#12736) disallowing CM to reassign some workers

["Benoit Hudson" <bh@xxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12736 >

New ticket since this is orthogonal to Per's idea.  Summary: 

> Powerful but bulky.  I'd suggest making it a pointer so it may be set to
> NULL to be easily disabled.

Bulky in what sense?  We don't pass cm_parameters around much, so the 
performance impact is minimal.  In terms of CM users, users that don't
care can just call leave it alone (cm_init_parameter will zero it out).  It's
also easy to add a cm_init_parameter_x call to do whatever special subset
we want (like all but one DEFAULT_SPECIALIST).

I think a pointer would be bulkier.

> for unmanaged cities this is clearly wrong, and can be very bad (see
> PR#11144).  I think in this case the CM shouldn't be run at all.

Indeed.  auto-arrange-workers should probably not be called by
update_city_map_etc_etc on human players; instead, we should
send a packet suggesting to re-run CM.