[Freeciv-Dev] (PR#12556) Killing a diplomat while infiltrating gets reported twice

["Brendon" <yautja@xxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12556 >

This has been in 2.0 for as long as I can remember, but only recently 
investigated the city first to confirm my suspicions.

I think the second 2 function calls in
server/diplomats.c - line:1139 - diplomat_infiltrate_tile
are obsolete code that wasn't removed somehow.

-----------------------------
        notify_player_ex(cplayer, ptile, E_MY_DIPLOMAT_FAILED,
                         _("Your %s has been eliminated defending %s"
                           " against a %s."), unit_name(punit->type),
                (pcity ? pcity->name : ""), unit_name(pdiplomat->type));
        notify_player_ex(pplayer, ptile, E_ENEMY_DIPLOMAT_FAILED,
                 _("An enemy %s has been eliminated defending %s."),
                unit_name(punit->type), (pcity ? pcity->name : ""));

        notify_player_ex(cplayer, pcity->tile, E_MY_DIPLOMAT_FAILED,
                         _("Your %s has been eliminated defending"
                           " against a %s in %s."), unit_name(punit->type),
                         unit_name(pdiplomat->type), pcity->name);
        notify_player_ex(pplayer, pcity->tile, E_ENEMY_DIPLOMAT_FAILED,
                         _("An enemy %s has been eliminated defending"
                           " %s."), unit_name(punit->type), pcity->name);