[Freeciv-Dev] (PR#12546) Divide handicaps to real handicaps and cheats

["Marko Lindqvist" <marko.lindqvist@xxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12546 >


  Handicaps need cleanup.

  Currently some handicaps really are handicaps (relative to rules) and 
some are cheats. It's not always clear if given 'handicap' is positive 
or negative thing to have. For more self documenting code there should 
be separate ai_handicap() and ai_cheat() functions.
  Further, ai_handicap() currently returns TRUE for human players. For 
some (current) handicaps this is ok, for some it's wrong. So sometimes 
it's callers responsibility to check that human players are handled 
correctly, sometimes caller can rely on ai_handicap() return value.


  - ML