Complete.Org: Mailing Lists: Archives: freeciv-dev: March 2005:
[Freeciv-Dev] (PR#12080) L(oaded) icon update
Home

[Freeciv-Dev] (PR#12080) L(oaded) icon update

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: chrisk@xxxxxxxxx
Subject: [Freeciv-Dev] (PR#12080) L(oaded) icon update
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Wed, 16 Mar 2005 11:46:36 -0800
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12080 >

> [chrisk - Tue Mar 15 17:23:02 2005]:
> 
> 
> PR#12080 contains several problems with the icon update.
> 
> The first has been fixed.
> 
> I have changed status from 'fixed' to 'open'.
> 
> Here is another reproducible problem. I load savegame up to RT:
> 
> Open city of Minneapolis. You see two sentried units. Using 'load'
> command from the context menue will *not* show the 'L' icon.

Good report.  I believe this patch fixes the problem (for both branches).

-jason

Index: client/packhand.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/packhand.c,v
retrieving revision 1.478
diff -u -r1.478 packhand.c
--- client/packhand.c   15 Mar 2005 16:11:40 -0000      1.478
+++ client/packhand.c   16 Mar 2005 19:43:15 -0000
@@ -961,7 +961,6 @@
   if (punit) {
     ret = TRUE;
     punit->activity_count = packet_unit->activity_count;
-    punit->transported_by = packet_unit->transported_by;
     punit->occupy = packet_unit->occupy;
     if (punit->ai.control != packet_unit->ai.control) {
       punit->ai.control = packet_unit->ai.control;
@@ -1046,6 +1045,7 @@
          refresh_unit_city_dialogs(ptrans);
        }
       }
+      punit->transported_by = packet_unit->transported_by;
 
     } /*** End of Change in activity or activity's target. ***/
     

[Prev in Thread] Current Thread [Next in Thread]