Complete.Org: Mailing Lists: Archives: freeciv-dev: March 2005:
[Freeciv-Dev] Re: (PR#12434) Fix two wonder city bugs
Home

[Freeciv-Dev] Re: (PR#12434) Fix two wonder city bugs

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: per@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#12434) Fix two wonder city bugs
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Sat, 5 Mar 2005 14:50:37 -0800
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12434 >

Per I. Mathisen wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=12434 >
> 
> The new wonder city code has two bugs that are fixed in the attached
> patch:
>  - if your wonder city is destroyed, the wonder city pointer is left
> dangling
>  - if you lose you wonder city to another player, this is not updated
> properly

I don't think AI code like this should go into the server.  Either:

1.  A generic ai_city_removed hook should be added, or

2.  In this particular case referring to the city by ID rather than 
pointer will allow checking for an invalidated city.

-jason





[Prev in Thread] Current Thread [Next in Thread]