[Freeciv-Dev] Re: (PR#12033) Hoover Damm does not give ecologic benefits

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12033 >

Jason Short wrote:

> I think for 2.0 we have to change the buildings.ruleset to match what 
> the docs say.  For the dev branch we could just change the docs.

And here are patches.  If you get a chance make sure hydro-2.0.diff 
works as expected (with one of the 2.0 betas).

-jason

? patch.diff
? win32.diff
Index: data/default/buildings.ruleset
===================================================================
RCS file: /home/freeciv/CVS/freeciv/data/default/buildings.ruleset,v
retrieving revision 1.57.2.3
diff -u -r1.57.2.3 buildings.ruleset
--- data/default/buildings.ruleset      4 Dec 2004 09:27:29 -0000       1.57.2.3
+++ data/default/buildings.ruleset      28 Jan 2005 08:08:47 -0000
@@ -580,8 +580,8 @@
     { "name", "value", "equiv", "req_type", "req"
       "Prod_Bonus", 25, "Generators", "Building", "Factory"
       "Prod_Bonus", 25, "Generators", "Building", "Mfg. Plant"
-      "Pollu_Prod_Pct", -25, "Janitors", "Building", "Factory"
-      "Pollu_Prod_Pct", -25, "Janitors", "Building", "Mfg. Plant"
+; Changed to a flat -50% for 2.0 to match what the docs say
+      "Pollu_Prod_Pct", -50, "Janitors"
     }
 sound          = "b_hydro_plant"
 sound_alt      = "b_generic"
@@ -1654,8 +1654,8 @@
     { "name", "range", "value", "equiv", "req_type", "req"
       "Prod_Bonus", "Player", 25, "Generators", "Building", "Factory"
       "Prod_Bonus", "Player", 25, "Generators", "Building", "Mfg. Plant"
-      "Pollu_Prod_Pct", "Player", -25, "Janitors", "Building", "Factory"
-      "Pollu_Prod_Pct", "Player", -25, "Janitors", "Building", "Mfg. Plant"
+; Changed to a flat -50% for 2.0 to match what the docs say
+      "Pollu_Prod_Pct", "Player", -50, "Janitors"
     }
 sound          = "w_hoover_dam"
 sound_alt      = "w_generic"

Index: data/default/buildings.ruleset
===================================================================
RCS file: /home/freeciv/CVS/freeciv/data/default/buildings.ruleset,v
retrieving revision 1.64
diff -u -r1.64 buildings.ruleset
--- data/default/buildings.ruleset      21 Dec 2004 03:36:19 -0000      1.64
+++ data/default/buildings.ruleset      28 Jan 2005 08:06:09 -0000
@@ -534,7 +534,8 @@
 sound_alt      = "b_generic"
 helptext       = _("\
 Reduces the amount of pollution generated by production in a city\
- by 50%.  It also\
+ by 25% in conjunction with a Factory and another 25% in conjunction with
+ a Manufacturing Plant.  It also\
  increases the shield production of a Factory or Mfg. Plant in the\
  city: a Factory and a Hydro Plant together give a 75% production\
  bonus, and a Factory, Mfg. Plant and Hydro Plant together give\