[Freeciv-Dev] Re: (PR#12033) Hoover Damm does not give ecologic benefits

["Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12033 >

On Fri, 28 Jan 2005, Jason Short wrote:

>
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=12033 >
>
> Jason Short wrote:
>
> > I think for 2.0 we have to change the buildings.ruleset to match what
> > the docs say.  For the dev branch we could just change the docs.
>
> And here are patches.  If you get a chance make sure hydro-2.0.diff
> works as expected (with one of the 2.0 betas).

This is how the pre-effects code did it:
 1870: static void set_pollution(struct city *pcity)
 1871: {
 1872:   struct player *pplayer = city_owner(pcity);
 1873:
 1874:   pcity->pollution = pcity->shield_prod;
 1875:   if (city_got_building(pcity, B_RECYCLING))
 1876:     pcity->pollution /= 3;
 1877:   else if (city_got_building(pcity, B_HYDRO) ||
 1878:     city_affected_by_wonder(pcity, B_HOOVER) ||
 1879:     city_got_building(pcity, B_NUCLEAR))
 1880:     pcity->pollution /= 2;
 1881:
 1882:   if (!city_got_building(pcity, B_MASS)) {
 1883:     pcity->pollution += (pcity->size *
 1884:                   num_known_tech_with_flag
 1885:                   (pplayer, TF_POPULATION_POLLUTION_INC)) / 4;
 1886:   }
 1887:
 1888:   pcity->pollution = MAX(0, pcity->pollution - 20);
 1889: }

So you should apply that patch that changes the ruleset to both branches.
But remember to change the Nuclear Plant as well.

I made a mistake on this ruleset effect definition I guess.

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa