Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2004:
[Freeciv-Dev] Re: (PR#11591) [Wislist] __attribute__ format for logging
Home

[Freeciv-Dev] Re: (PR#11591) [Wislist] __attribute__ format for logging

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Subject: [Freeciv-Dev] Re: (PR#11591) [Wislist] __attribute__ format for logging functions
From: "Marko Lindqvist" <marko.lindqvist@xxxxxxxxxxx>
Date: Sat, 18 Dec 2004 10:34:59 -0800
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=11591 >

Marko Lindqvist wrote:
> 
>   Using gcc's '__attribute__ ((format (printf, ?, ?)))' for logging (and 
> some other) functions would catch problems like #11589 when they first 
> appear.

  Oh, it's already done for some log functions through fc__attribute.
  Using fc__attribute for any gcc __attribute__ seem a bit wrong though. 
We should give separate macro for each __attribute__ type we use, so we 
don't break old (or new?) versions of gcc by using unsupported 
__attribute__.


  - ML





[Prev in Thread] Current Thread [Next in Thread]