[Freeciv-Dev] (PR#11386) Should popup_intel_dialog be rewritten like popup_spaceship_dialog?

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=11386 >

> [evyscr - Tue Dec 07 19:40:16 2004]:
> 
> Good daytime!
> 
> Now we have a function 'popup_intel_dialog(player *pplayer)' which looks
> for existing intel_dialog (no matter about pplayer).
> 
> 'popup_spaceship_dialog(pplayer)' has a call to function
> 'get_spaceship_dialog(pplayer)' in check for exisiting dialog.
> 
> Should 'popup_intel_dialog' use similar call in check?

You mean so that you can have one dialog for each player?  I'd say it
could be done either way, but should probably be consistent between
spaceship and intel dialogs.  And you need to make sure the behavior
when popping up an intel dialog while one already exists is sane (the
gtk2 client is buggy in this regard).

-jason