[Freeciv-Dev] Re: (PR#11271) get_food_trade_shields isn't good

["Per I. Mathisen" <per@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=11271 >

On Tue, 30 Nov 2004, Jason Short wrote:
> What is the purpose of the get_food_trade_shields() function?

Calculate the exact benefits of a city in terms of output factors.

> This function should be moved out of city.c and into aicity.c.

But it is used in city.c too, as part of generic_city_refresh.

> In fact I think it's buggy because the caller (city_want) doesn't
> account for specialists, and neither does get_food_trade_shields().

Oh, this is bad. I am sure the code did this at one time, but it must have
gotten lost during one of the many rewrites.

  - Per