Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2004:
[Freeciv-Dev] Re: (PR#11271) get_food_trade_shields isn't good
Home

[Freeciv-Dev] Re: (PR#11271) get_food_trade_shields isn't good

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Subject: [Freeciv-Dev] Re: (PR#11271) get_food_trade_shields isn't good
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Wed, 8 Dec 2004 08:46:13 -0800
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=11271 >

Per I. Mathisen wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=11271 >
> 
> On Thu, 2 Dec 2004, Jason Short wrote:
> 
>>- get_food_trade_shields is renamed as get_worked_tile_output. ...
>>- A new function in city.c is separated out: add_specialist_output. ...
>>- A single function get_citizen_output() is provided to the interface.
> 
> A simpler and more generalized patch that works with current cvs attached.
> In particular get_tax_income() has been changed.

get_tax_income needs better documentation and should probably be renamed 
as add_tax_income.  Otherwise the patch looks fine.  (I considered 
changing get_tax_income like this but decided it wasn't worth it.  But 
either way is fine with me.)

jason





[Prev in Thread] Current Thread [Next in Thread]