Complete.Org: Mailing Lists: Archives: freeciv-dev: November 2004:
[Freeciv-Dev] (PR#11105) gtk2-client revolution bug
Home

[Freeciv-Dev] (PR#11105) gtk2-client revolution bug

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Subject: [Freeciv-Dev] (PR#11105) gtk2-client revolution bug
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Sat, 20 Nov 2004 10:28:28 -0800
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=11105 >

- Start an untargeted revolution.
- Let it run to completion.
- Let it run another turn.
- Now choose a government from the dialog.

You will erronously get the confirmation popup.  This patch fixes it.

jason

Index: client/gui-gtk-2.0/dialogs.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/gui-gtk-2.0/dialogs.c,v
retrieving revision 1.82
diff -u -r1.82 dialogs.c
--- client/gui-gtk-2.0/dialogs.c        17 Nov 2004 18:04:40 -0000      1.82
+++ client/gui-gtk-2.0/dialogs.c        20 Nov 2004 18:26:08 -0000
@@ -1028,7 +1028,7 @@
 {
   static GtkWidget *shell = NULL;
 
-  if (game.player_ptr->revolution_finishes < game.turn) {
+  if (game.player_ptr->revolution_finishes == -1) {
     if (!shell) {
       shell = gtk_message_dialog_new(NULL,
          0,

[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] (PR#11105) gtk2-client revolution bug, Jason Short <=