[Freeciv-Dev] Re: (PR#10913) option interface bugs

["Christian Knoke" <chrisk@xxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10913 >

On Sat, Nov 06, 2004 at 11:55:40AM -0800, Jason Short wrote:
> 
> > chris: 'set notradesize 1'
> > /set: notradesize must be always smaller than fulltradesize; keeping old
> > value.
> > chris: 'set fulltradesize 4'
> > fulltradesize auf 4 gesetzt.
> 
> But doing it the other way would also be wrong if you set fulltradesize 
> to be smaller than notradesize (which is admittedly much less likely).

But this is an illegal setting anyway; there is no problem with it, because
the civclient AFAICS transfers all options at the same time, after the user
has quitted the dialog.

We might consider to change the error handling in the server, to cut
notradesize down to fulltradesize in this case, though.

But the best is to control this in the dialog.

> We could reorder the settings to get "better" behavior.  This is a big 
> hack.  Or we could send each setting twice.  This is also a big hack. 
> Or we could disable pregame checking of notradesize and fulltradesize 
> and change the runtime code to handle invalid combinations.
> 
> I'd say the first method is best for S2_0 and the last method for the 
> development branch.
> 
> > Also, I cannot find the *tradesize options in the client option dialogs
> > (after the game has started).
> 
> It's not in "server options" or "server options initial".  Very odd.

Should be in initial options, economy.

> "Server options initial" should be removed.  The server options dialog 
> should show all options but unsettable ones just shouldn't be settable.

Yes. The initial options display hurts.

Christian

-- 
Christian Knoke            * * *            http://cknoke.de
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.