[Freeciv-Dev] (PR#10606) set_ai_level() violates principle of least surprise

["Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10606 >

For introductory help, type 'help'.
> hard
Default AI skill level set to 'hard'.
> create Joe
> easy
Player 'Joe' now has AI skill level 'easy'.
Default AI skill level set to 'easy'.
> create John
> /list
List of players:
------------------------------------------------------------------------------
Joe (user Unassigned, AI, difficulty level easy)
John (user Unassigned, AI, difficulty level easy)
------------------------------------------------------------------------------
> 

this is wrong. Joe, Ned, and Bob should be hard, because that was the
default skill level when they were created.

attached is a possible patch. minimally tested.

-mike

? server/.stdinhand.c.swp
Index: server/stdinhand.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/server/stdinhand.c,v
retrieving revision 1.354.2.4
diff -u -r1.354.2.4 stdinhand.c
--- server/stdinhand.c  9 Oct 2004 21:41:52 -0000       1.354.2.4
+++ server/stdinhand.c  19 Oct 2004 03:07:31 -0000
@@ -1761,14 +1761,6 @@
     if (check) {
       return TRUE;
     }
-    players_iterate(pplayer) {
-      if (pplayer->ai.control) {
-       set_ai_level_directer(pplayer, level);
-        cmd_reply(cmd_of_level(level), caller, C_OK,
-               _("Player '%s' now has AI skill level '%s'."),
-               pplayer->name, name_of_skill_level(level));
-      }
-    } players_iterate_end;
     game.skill_level = level;
     cmd_reply(cmd_of_level(level), caller, C_OK,
                _("Default AI skill level set to '%s'."),