Complete.Org: Mailing Lists: Archives: freeciv-dev: October 2004:
[Freeciv-Dev] Re: (PR#10471) [PATCH] Remove connection dialog
Home

[Freeciv-Dev] Re: (PR#10471) [PATCH] Remove connection dialog

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: vasc@xxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#10471) [PATCH] Remove connection dialog
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 17 Oct 2004 17:02:22 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10471 >

Vasco Alexandre da Silva Costa wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=10471 >
> 
> Version 4 adds a bunch of stuff requested by Jason and Mike. Better
> savename extension handling, a couple of comments, switch to network
> page before refreshing the list and fix a keyboard bug in certain
> versions of GTK+.

Functions in utility/ need header comments.  datafilelist_infix is not 
at all self-explanatory.

Another minor (IMO) issue is that if you

   /save .foo

you will get the same results as if you just did /save.  It is possible 
to fix this but is a lot of work for (IMO) little benefit.

jason




[Prev in Thread] Current Thread [Next in Thread]