[Freeciv-Dev] (PR#10459) bug: pplayer_can_ally assert fail

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10459 >

#3  0x400abb3f in *__GI___assert_fail (assertion=0x0, file=0x0, line=0,
    function=0x81504e4 "check_players") at assert.c:83
#4  0x080900cd in check_players ()
    at ../../freeciv-2.0/server/sanitycheck.c:386
#5  0x0809028f in sanity_check () at
../../freeciv-2.0/server/sanitycheck.c:434
#6  0x0804f3d5 in begin_phase (is_new_phase=true)
    at ../../freeciv-2.0/server/srv_main.c:543
#7  0x08050f82 in main_loop () at ../../freeciv-2.0/server/srv_main.c:1503
#8  0x08051885 in srv_loop () at ../../freeciv-2.0/server/srv_main.c:1872
#9  0x080511cf in srv_main () at ../../freeciv-2.0/server/srv_main.c:1622

(gdb) select 4
(gdb) p pplayer->player_no
$3 = 8
(gdb) p pplayer2->player_no
$4 = 2

(gdb) p pplayer->diplstates[2]
$13 = {type = DS_ALLIANCE, turns_left = 0, has_reason_to_cancel = 0,
  contact_turns_left = 17}
(gdb) p pplayer2->diplstates[8]
$14 = {type = DS_ALLIANCE, turns_left = 0, has_reason_to_cancel = 0,
  contact_turns_left = 17}

(gdb) p pplayer->diplstates[3]
$11 = {type = DS_WAR, turns_left = 16, has_reason_to_cancel = 0,
  contact_turns_left = 0}
(gdb) p pplayer2->diplstates[3]
$12 = {type = DS_ALLIANCE, turns_left = 16, has_reason_to_cancel = 0,
  contact_turns_left = 20}

So it is love-love-hate.  However more checking will have to be added
elsewhere to find out how this comes about.

jason