[Freeciv-Dev] (PR#10522) republic/democracy game balancing

["Per I. Mathisen" <per@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10522 >

This patch removes the automatic tile bonus for Republic and Democracy,
and replaces it with Marketplace and Library bonuses instead. This makes
the transition to Republic much less of an 'explosion' in research and
income, and makes it actually worthwhile to build Marketplace and Library
instead of just having lots of empty hamlets pouring in gold and science.

There are two problems with it as I see it:
  - there is much less corruption, as corruption is calculated from base
trade, and base trade does not increase as it would otherwise (bonus moved
from base trade to gold/lux)
  - the bonus is concentraded on two buildings very early in the
buildings tree; this is perhaps unavoidable in order to get somewhat the
same effect, but is aesthetically displeasing.

  - Per

Index: data/default/buildings.ruleset
===================================================================
RCS file: /home/freeciv/CVS/freeciv/data/default/buildings.ruleset,v
retrieving revision 1.58
diff -u -r1.58 buildings.ruleset
--- data/default/buildings.ruleset      13 Oct 2004 15:47:43 -0000      1.58
+++ data/default/buildings.ruleset      13 Oct 2004 22:42:57 -0000
@@ -620,8 +620,10 @@
 upkeep         = 1
 sabotage       = 100
 effect         =
-    { "name", "value"
+    { "name", "value", "req_type", "req"
       "Science_Bonus", 100
+      "Science_Bonus", 100, "Gov", "Republic"
+      "Science_Bonus", 100, "Gov", "Democracy"
     }
 sound          = "b_library"
 sound_alt      = "b_generic"
@@ -647,9 +649,13 @@
 upkeep         = 0
 sabotage       = 100
 effect         =
-    { "name", "value"
+    { "name", "value", "req_type", "req"
       "Tax_Bonus", 50
       "Luxury_Bonus", 50
+      "Tax_Bonus", 50, "Gov", "Republic"
+      "Luxury_Bonus", 50, "Gov", "Republic"
+      "Tax_Bonus", 50, "Gov", "Democracy"
+      "Luxury_Bonus", 50, "Gov", "Democracy"
     }
 sound          = "b_marketplace"
 sound_alt      = "b_generic"
Index: data/default/governments.ruleset
===================================================================
RCS file: /home/freeciv/CVS/freeciv/data/default/governments.ruleset,v
retrieving revision 1.24
diff -u -r1.24 governments.ruleset
--- data/default/governments.ruleset    20 Aug 2004 20:13:18 -0000      1.24
+++ data/default/governments.ruleset    13 Oct 2004 22:42:57 -0000
@@ -447,7 +447,7 @@
 waste_extra_distance       = 0
 waste_max_distance_cap     = 36
 
-production_trade_bonus    = 1, 1
+production_trade_bonus    = 0, 1
 production_shield_bonus   = 0, 0
 production_food_bonus     = 0, 0
 
@@ -532,7 +532,7 @@
 waste_extra_distance       = 0
 waste_max_distance_cap     = 36
 
-production_trade_bonus    = 1, 1
+production_trade_bonus    = 0, 1
 production_shield_bonus   = 0, 0
 production_food_bonus     = 0, 0