Complete.Org: Mailing Lists: Archives: freeciv-dev: October 2004:
[Freeciv-Dev] Re: (PR#10411) [Patch] VERSION_STRING -> freeciv_version_
Home

[Freeciv-Dev] Re: (PR#10411) [Patch] VERSION_STRING -> freeciv_version_

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: marko.lindqvist@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#10411) [Patch] VERSION_STRING -> freeciv_version_string()
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 3 Oct 2004 20:27:00 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10411 >

Marko Lindqvist wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=10411 >
> 
> 
>   Call new functions freeciv_version_string() and 
> freeciv_version_string_long() instead of using macro VERSION_STRING 
> directly. For now both functions returns exactly same string. _long() is 
> used only when producing output for commandline parameter '--version'.
> 
>   This is step towards #4712. Should I change all related macros into 
> functions in one big patch or should I make separate patches like this one?

Why not just change the value of the macro?  If that's not possible, we 
might as well do all similar changes in one patch (so long as it's just 
search-and-replace).

jason




[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] Re: (PR#10411) [Patch] VERSION_STRING -> freeciv_version_string(), Jason Short <=