Complete.Org: Mailing Lists: Archives: freeciv-dev: October 2004:
[Freeciv-Dev] Re: (PR#10389) logging of dead explorer
Home

[Freeciv-Dev] Re: (PR#10389) logging of dead explorer

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#10389) logging of dead explorer
From: "Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxxx>
Date: Sun, 3 Oct 2004 20:27:58 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10389 >

Isn't it an overkill (no pun intended)?

Can't we just check the unit id before logging it, as done in other parts
of the code?

On Thu, 30 Sep 2004, Per I. Mathisen wrote:

>
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=10389 >
>
> On Wed, 29 Sep 2004, Jason Short wrote:
> > but the unit is killed inside ai_manage_explorer so the second UNIT_LOG
> > results in some invalid memory accesses.
>
> But how could the unit die in the explorer code? This should not be
> possible. So we probably have two bugs here.
>
> Here is a patch for the first bug. It makes ai_manage_explorer() pass a
> pointer to a unit pointer, as suggested by Jason on irc.
>
>   - Per
>
>




[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] Re: (PR#10389) logging of dead explorer, Gregory Berkolaiko <=