Complete.Org: Mailing Lists: Archives: freeciv-dev: September 2004:
[Freeciv-Dev] Re: (PR#10128) improve eff building code
Home

[Freeciv-Dev] Re: (PR#10128) improve eff building code

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: per@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#10128) improve eff building code
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Wed, 15 Sep 2004 09:15:25 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10128 >

Inlining city_want seems missplaced, since it calls 5 other functions 
which themselves call numerous functions.  You may be able to 
short-circuit it by skipping any entries that are 0.

Other changes look good, though I'm no expert.

jason




[Prev in Thread] Current Thread [Next in Thread]