[Freeciv-Dev] Re: (PR#10090) multiple applications of a single effect type

["Per I. Mathisen" <per@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10090 >

On Mon, 13 Sep 2004, Jason Short wrote:
> However elsewhere there is a problem with additive summing.In
> city_pollution() there is a check for the applicable effect amount from
> EFT_POLLU_PROD_PCT.If this value exists then the pollution is divided
> by that ammount.However in the previous rules these were combined
> multiplicatively, so the two effects of amounts "2" and "3" would
> combine to a 6x bonus.
>
> A related problem is in base_get_trade_tile, where there are a whole
> bunch of effects to add to or multiply the tile's trade output by.
> These are applied in a hard-coded order that cannot be controlled by the
> ruleset.Moreover there are some government, terrain, and special-based
> effects (bonuses and penalties which aren't implemented as effects yet,
> but should be) that must be applied in a particular order as well.
...
> My idea to solve this is to add a new parameter to each effect, called
> "which"

Is this absolutely necessary? We can change the rules slightly instead. I
am willing to sacrifice a lot of nobody-but-purists-care civ2
compatibility in order to avoid such ugliness.

  - Per