Complete.Org: Mailing Lists: Archives: freeciv-dev: September 2004:
[Freeciv-Dev] Re: (PR#10051) max_players change on load
Home

[Freeciv-Dev] Re: (PR#10051) max_players change on load

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: marko.lindqvist@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#10051) max_players change on load
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 12 Sep 2004 18:55:17 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10051 >

Brett Albertson wrote:

> I think the problem is in line 1796 of srv_main.c.  It sets the 
> max_players to the number of players it finds upon iterating through 
> the players.  It overwrites the max_players it gets from the saved 
> game.  I assume this should check if the game was loaded and only set 
> max_players if it was not loaded.

Or make sure this is done every turn, or at least before the game was 
saved.  That way the value isn't changed on loading.

But probably your method is better; it preserves the max_players from 
the beginning of the game.

jason




[Prev in Thread] Current Thread [Next in Thread]