[Freeciv-Dev] Re: (PR#9995) RfP: is_sane_name and user names

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9995 >

Mateusz Stefek wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=9995 >
> 
> There's a problem:
> When we run out of default city names, the algorithm proposes cities
> from civilwar_nation lists. Some of these names can be illegal for the
> original nation.

That _is_ a problem.  We should fix it but it won't be easy.

However note that these city names shouldn't be offered to you by 
default, since is_allowed_city_name is called when picking a name to 
offer, and it will return FALSE for these.  I think this behavior is 
acceptable but not ideal.

However also note that under the check_names patch, search_for_city_name 
has become pretty slow.  O(n^2) at best.  Having it search through for 
the current nation list and allow any nations for that would make it 
much slower.

I think all of this is fixable, but it means changing the data 
structures to allow a more efficient search.

jason