[Freeciv-Dev] (PR#9553) Bug: self "unknown" in Intelligence Info

["Mateusz Stefek" <mstefek@xxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9553 >

> [chrisk - Wed Aug 18 20:10:36 2004]:
> 
> On Wed, Aug 18, 2004 at 10:02:50AM -0700, Jason Short wrote:
> >
> > <URL: http://rt.freeciv.org/Ticket/Display.html?id=9553 >
> >
> > > [chrisk - Fri Jul 30 09:12:24 2004]:
> > >
> > >
> > > CVS 30 JUL 2004 GTK2
> > >
> > > The player dialog --> Intelligence --> Diplomacy lists myself as
> unknown.
> >
> > >From inside the player dialog, I can't pop up the intelligence
> dialog
> > for myself.
> 
> Sorry. I mean this: the diplomacy window for an AI player lists *that*
> AI
> player as unknown. The AI doesn't know itself. Not really wrong ;)
> 
> It is supposed to list the relationships of that AI player to other
> nations.
> 
> Christian
> 
Here's a patch
--
mateusz

? civgame-3500.sav.gz
Index: gui-gtk-2.0/inteldlg.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/gui-gtk-2.0/inteldlg.c,v
retrieving revision 1.14
diff -u -r1.14 inteldlg.c
--- gui-gtk-2.0/inteldlg.c      18 Jul 2004 04:19:27 -0000      1.14
+++ gui-gtk-2.0/inteldlg.c      3 Sep 2004 07:46:04 -0000
@@ -215,6 +215,9 @@
     GtkTreeIter it;
     GValue v = { 0, };
 
+    if (other == p) {
+      continue;
+    }
     state = pplayer_get_diplstate(p, other);
     gtk_tree_store_append(tree, &it, &diplstates[state->type]);
     g_value_init(&v, G_TYPE_STRING);