[Freeciv-Dev] (PR#9716) fill_ranges_improv_lists assert

["Guest" <rt-guest@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9716 >

> [jdorje - Wed Aug 18 17:51:51 2004]:
> 
> This patch removes the "bad" assertion.
> 
> jason

Simply removing the assert() does not fix the problem.  Somewhere down the 
line, the 
program crashes with a Bus error, at least on Mac OS X.  Here's the stack dump 
from crash if 
the patch removes the assertion:


Program received signal EXC_BAD_ACCESS, Could not access memory.
0x0002ca5c in get_citizen_pixmap (type={type = 755948, spec_type = 781688}, 
cnum=0, 
pcity=0x1800800) at mapview.c:260
260     mapview.c: No such file or directory.
        in mapview.c
(gdb) where
#0  0x0002ca5c in get_citizen_pixmap (type={type = 755948, spec_type = 781688}, 
cnum=0, pcity=0x1800800) at mapview.c:260
#1  0x0002e534 in popup_city_dialog (pcity=0x4, make_modal=2) at citydlg.c:417
#2  0x0001a324 in handle_city_packet_common (pcity=0x1800800, is_new=2, 
popup=15, 
investigate=25167872) at packhand.c:609
#3  0x0001a084 in handle_city_info (packet=0xf) at packhand.c:535
#4  0x0001eae8 in client_handle_packet (type=PACKET_PROCESSING_STARTED, 
packet=0x0) 
at packhand_gen.c:115
#5  0x00006334 in handle_packet_input (packet=0x0, type=25167872) at 
civclient.c:274
#6  0x00009850 in input_from_server (fd=0) at clinet.c:328
#7  0x8584c018 in DoOtherSources ()
#8  0x8584c480 in XtAppNextEvent ()
#9  0x85840ca4 in XtAppMainLoop ()
#10 0x000327c0 in ui_main (argc=1, argv=0x80) at gui_main.c:460