[Freeciv-Dev] Re: (PR#9716) fill_ranges_improv_lists assert

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9716 >

Jason Short wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=9716 >
> 
> #5  0x4071bb3f in *__GI___assert_fail (assertion=0x0, file=0x0, line=0,
>      function=0x81664b6 "fill_ranges_improv_lists") at assert.c:83
> #6  0x080f1fbe in fill_ranges_improv_lists (equiv_list=0xbffff4c0,
>      pcity=0x83bca70, pplayer=0x8199cc0) at improvement.c:289
> #7  0x080f23f5 in mark_improvement (pcity=0x83bca70, id=B_CITY,
>      status=1 '\001') at improvement.c:464
> #8  0x080ea7da in city_add_improvement (pcity=0x83bca70, impr=B_CITY)
>      at city.c:2594
> #9  0x0808537f in update_improvement_from_packet (pcity=0x83bca70,
>      impr=B_CITY, have_impr=true, impr_changed=0xbffff561) at packhand.c:308
> #10 0x08086263 in handle_city_short_info (packet=0x83ff118) at 
> packhand.c:703
> #11 0x0808ca94 in client_handle_packet (type=PACKET_CITY_SHORT_INFO,
>      packet=0x83ff118) at packhand_gen.c:119
> #12 0x0806f208 in handle_packet_input (packet=0x83ff118, type=22)
>      at civclient.c:274
> #13 0x08072ee0 in input_from_server (fd=4) at clinet.c:328
> #14 0x080bb476 in get_net_input (data=0x0, fid=4, condition=GDK_INPUT_READ)
>      at gui_main.c:1456
> #15 0x4031919b in gdk_get_show_events () from /usr/lib/libgdk-x11-2.0.so.0

It's worth pointing out that this assertion was added by the 
ocean-continents patch.  So this behavior may have existed all along. 
Removing it will probably allow the game to run, but I can't see any way 
around this being a bug.  It should be fixed.

jason