[Freeciv-Dev] Re: (PR#7338) [RfP] Ocean numbers

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7338 >

Marcelo Burda wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=7338 >
> 
>>[glip - Mer. Jan. 28 21:11:18 2004]: 
>> 
> 
>   Positive numbers are reserved for 
> 
>>the land 
>>continent, so we can use negative ones.   
> 
> My first patch done this but i think this is wrong, first ocean city 
> mus have a continent number then i has to correct this too to alow 
> negative indices, second this is bad of test for ocean with the signus 
> of continent number, there is a is_ocean() macro for it.  
> for me a ocean as a continent numer. (read: point) I collect it at end  
> to eventually sort it by size (but i am not sure if it is necesary, ia 
> can read directly the size array to especulate about makin or not a 
> trireme) 

I think eventually oceans should have continent numbers 
indistinguishable from land continent numbers.  But this may take some 
more work to fix.  For now the simple solution is okay.

jason