[Freeciv-Dev] (PR#9675) city tiles arrays aren't freed

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9675 >

==6067== 2089 bytes in 77 blocks are definitely lost in loss record 125 
of 150
==6067==    at 0x1B904EDD: malloc (vg_replace_malloc.c:131)
==6067==    by 0x80DECE6: fc_real_malloc (mem.c:79)
==6067==    by 0x80DEDDB: fc_real_calloc (mem.c:124)
==6067==    by 0x809B922: tilespec_alloc_city_tiles (tilespec.c:2860)
==6067==    by 0x808940D: handle_ruleset_control (packhand.c:2190)
==6067==    by 0x808CDEA: client_handle_packet (packhand_gen.c:303)
==6067==    by 0x806F227: handle_packet_input (civclient.c:274)
==6067==    by 0x8072E87: input_from_server (clinet.c:328)
==6067==    by 0x80BB391: get_net_input (gui_main.c:1456)
==6067==    by 0x1BC0E19A: (within /usr/lib/libgdk-x11-2.0.so.0.400.4)
==6067==    by 0x1BD93F2E: (within /usr/lib/libglib-2.0.so.0.400.5)
==6067==    by 0x1BD6E901: (within /usr/lib/libglib-2.0.so.0.400.5)
==6067==    by 0x1BD6F9F7: g_main_context_dispatch (in 
/usr/lib/libglib-2.0.so.0.400.5)
==6067==    by 0x1BD6FD2F: (within /usr/lib/libglib-2.0.so.0.400.5)
==6067==    by 0x1BD70372: g_main_loop_run (in 
/usr/lib/libglib-2.0.so.0.400.5)
==6067==    by 0x1BA36712: gtk_main (in /usr/lib/libgtk-x11-2.0.so.0.400.4)
==6067==    by 0x80BA95A: ui_main (gui_main.c:1205)
==6067==    by 0x806F1DA: main (civclient.c:245)

These arrays are allocated at the beginning of every game.  If the 
tileset changes they are freed and reallocated.  But if you disconnect 
and reconnect they are not freed.

IMO these arrays should just be of fixed size.

jason