[Freeciv-Dev] Re: (PR#9424) Bug: can't establish trade with non-allies with CVS 20040718

["James Christensen" <jmlchristensen@xxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9424 >

--- Gregory Berkolaiko <Gregory.Berkolaiko@xxxxxxxxxxxxx> wrote:

> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=9424 >
> 
> Dear patch author,
> 
> (please sign your email next time ;)
>

But then I'd be forced to find (and even attempt to fix) more bugs. I might
even have to get an RT account (gasp). Ha, you'll never find out who I am! 
> 
> It seems to be a good patch.  What strikes me is that this bug existed for
> at least a year, shows how many people bother about trade routes!

Yeah, maybe using them for building wonders shouldn't be so efficient.
 
> Anyway, I can commit the patch as is.
> 
> Or we can fix some more things on the way:
> 1. When a caravan is homeless, we need a notify,
> so remove the check in handle_unit_move_request and add a message
> to base_...
> 
> 2. When !can_cities_trade we also need a notify (although it probably
> never happens).
>
> 3. (optional) Fix formatting in notifies

Okay, these look easy enough. 
  
> 4. (compulsory) Continue finding bugs and contributing patches.

See, I told you.

James


                
__________________________________
Do you Yahoo!?
New and Improved Yahoo! Mail - Send 10MB messages!
http://promotions.yahoo.com/new_mail