[Freeciv-Dev] Re: (PR#9424) Bug: can't establish trade with non-allies with CVS 20040718

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9424 >

Dear patch author,

(please sign your email next time ;)

On Sat, 7 Aug 2004, Guest wrote:

> <URL: http://rt.freeciv.org/Ticket/Display.html?id=9424 >
>
> The problem still exists with current CVS.
>
> I wasn't sure what approach to fixing this would be preferred, so I
> didn't send a patch, but seeing as things are still broken (nobody uses
> trade units to ... trade?), here's a patch that works for me.

It seems to be a good patch.  What strikes me is that this bug existed for
at least a year, shows how many people bother about trade routes!

Anyway, I can commit the patch as is.

Or we can fix some more things on the way:
1. When a caravan is homeless, we need a notify,
so remove the check in handle_unit_move_request and add a message
to base_...

2. When !can_cities_trade we also need a notify (although it probably
never happens).

3. (optional) Fix formatting in notifies

4. (compulsory) Continue finding bugs and contributing patches.

If I don't hear from you for a couple of days, I will commit the patch as
is.

Best wishes,
G.