Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2004:
[Freeciv-Dev] Re: (PR#9593) another autosettlers patch
Home

[Freeciv-Dev] Re: (PR#9593) another autosettlers patch

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#9593) another autosettlers patch
From: "Per I. Mathisen" <per@xxxxxxxxxxx>
Date: Tue, 3 Aug 2004 03:09:29 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9593 >

On Mon, 2 Aug 2004, Jason Short wrote:
> - Changes the structure of the functions slightly to be more similar. I
> added an "r" variable to ai_calc_irrigate and ai_calc_mine.

This is a retrogression to Syelaism. IMHO, variables should either be
descriptive, so that the code can be understood from a casual glance at
it, or, if the benefits are great enough to warrant using something
cryptic, explained in the function header.

  - Per




[Prev in Thread] Current Thread [Next in Thread]