[Freeciv-Dev] (PR#9513) Patch: connection id in chat
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
<URL: http://rt.freeciv.org/Ticket/Display.html?id=9513 >
Two more problems:
- There is a global server variable current_connection added into the
common code. This is quite bad IMO. It is error-prone and makes the
logic a lot more complicated.
- The code for "no connection" is 255. However AFAICT there could be
255 connections. I don't really know what the limit on the number on
the number of connections is. This isn't really a bug in the patch
though, but in the current code where packets.def defines a CONNECTION
as a uint8.
jason
|
|