Complete.Org: Mailing Lists: Archives: freeciv-dev: July 2004:
[Freeciv-Dev] (PR#9513) Patch: connection id in chat
Home

[Freeciv-Dev] (PR#9513) Patch: connection id in chat

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: per@xxxxxxxxxxx
Subject: [Freeciv-Dev] (PR#9513) Patch: connection id in chat
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Wed, 28 Jul 2004 13:43:03 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9513 >

Two more problems:

- There is a global server variable current_connection added into the
common code.  This is quite bad IMO.  It is error-prone and makes the
logic a lot more complicated.

- The code for "no connection" is 255.  However AFAICT there could be
255 connections.  I don't really know what the limit on the number on
the number of connections is.  This isn't really a bug in the patch
though, but in the current code where packets.def defines a CONNECTION
as a uint8.

jason



[Prev in Thread] Current Thread [Next in Thread]