Complete.Org: Mailing Lists: Archives: freeciv-dev: July 2004:
[Freeciv-Dev] Re: (PR#9513) Patch: connection id in chat
Home

[Freeciv-Dev] Re: (PR#9513) Patch: connection id in chat

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: per@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#9513) Patch: connection id in chat
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Tue, 27 Jul 2004 11:13:29 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9513 >

And this part is also quite bad

+    remaining.lines++;
+    remaining.line =
+       fc_realloc(remaining.line,
+                  remaining.lines * sizeof(*remaining.line));

since it will result in hideous amounts of reallocation.  Instead a 
specvec should be used.

jason




[Prev in Thread] Current Thread [Next in Thread]