[Freeciv-Dev] (PR#9372) handle_unit_load fails, causes aiferry assertion

["Jason Dorje Short" <jdorje@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9372 >

I got a segfault in aiferry.c:452.  handle_unit_load() is called to load 
a unit, then the code asserts that the unit is loaded.  But 
handle_unit_load can fail if the conditions are not right, and since 
this is a handle() function it does so silently.  The result is a failed 
assertion.

I guess the code above needs to check the conditions more carefully.

#0  0x400b3721 in kill () from /usr/lib/debug/libc.so.6
#1  0x400b34c5 in *__GI_raise (sig=6)
     at ../linuxthreads/sysdeps/unix/sysv/linux/raise.c:32
#2  0x400b49e8 in *__GI_abort () at ../sysdeps/generic/abort.c:88
#3  0x400acb3f in *__GI___assert_fail (assertion=0x0, file=0x0, line=0,
     function=0x817279f "aiferry_gobyboat") at assert.c:83
#4  0x081337f8 in aiferry_gobyboat (pplayer=0x81cce4c, punit=0x837f7b8,
     dest_x=31, dest_y=18) at aiferry.c:452
#5  0x08138133 in ai_gothere (pplayer=0x81cce4c, punit=0x837f7b8, dest_x=31,
     dest_y=18) at aitools.c:231
#6  0x080af816 in auto_settler_findwork (pplayer=0x81cce4c, punit=0x837f7b8)
     at settlers.c:1266
#7  0x080afe09 in auto_settlers_player (pplayer=0x81cce4c) at 
settlers.c:1357
#8  0x080b05a3 in auto_settlers () at settlers.c:1502
#9  0x0804f015 in end_phase () at srv_main.c:561
#10 0x08050ada in main_loop () at srv_main.c:1468
#11 0x0805129b in srv_loop () at srv_main.c:1758
#12 0x08050c63 in srv_main () at srv_main.c:1545
#13 0x0804a5df in main (argc=6, argv=0xbffff854) at civserver.c:161

jason