Complete.Org: Mailing Lists: Archives: freeciv-dev: July 2004:
[Freeciv-Dev] (PR#9369) disable automatic detection of the XAW client
Home

[Freeciv-Dev] (PR#9369) disable automatic detection of the XAW client

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: undisclosed-recipients: ;
Subject: [Freeciv-Dev] (PR#9369) disable automatic detection of the XAW client
From: "Jason Dorje Short" <jdorje@xxxxxxxxxxx>
Date: Tue, 13 Jul 2004 08:51:59 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9369 >

My studies of the pubserver connection statistics have lead me to 
believe that 95-99% of players who use the XAW client do so by mistake. 
  Probably they are on a platform that should support the gtk2 client 
but don't have those libraries installed.  So when they run ./configure 
the XAW client is automatically detected.

This is not good.  Automatic detection is convenient but anyone on a 
platform that needs the XAW client (are there any?) can surely look at 
the output of configure to find this info.

So this patch disables automatic detection of the XAW client.

Note that this automatic detection was broken anyway since, unlike the 
other clients, it would cause configure to fail if the client was not found.

Does anyone object to this change?

jason

Index: m4/xaw-client.m4
===================================================================
RCS file: /home/freeciv/CVS/freeciv/m4/xaw-client.m4,v
retrieving revision 1.1
diff -u -r1.1 xaw-client.m4
--- m4/xaw-client.m4    13 Jul 2004 15:29:51 -0000      1.1
+++ m4/xaw-client.m4    13 Jul 2004 15:48:20 -0000
@@ -5,7 +5,9 @@
 
 AC_DEFUN([FC_XAW_CLIENT],
 [
-  if test "$client" = xaw || test "$client" = yes ; then
+  if test "$client" = yes ; then
+    AC_MSG_WARN([Not checking for XAW; use --enable-client=xaw to enable])
+  elif test "$client" = xaw ; then
     dnl Checks for X:
     AC_PATH_XTRA
 

[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] (PR#9369) disable automatic detection of the XAW client, Jason Dorje Short <=