[Freeciv-Dev] Re: (PR#9105) one final mapview optimization

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9105 >

This is however a bit complicated, because window and store positions 
are no longer the same.

Most users of map_to_canvas_pos() use their results to draw to the 
canvas store.  This must be done in store positions.

However most users of canvas_to_map_pos() get their input from the GUI 
widget.  This comes in window positions.

So either we break canvas positions up into window and store positions 
(map_to_window_pos(), map_to_store_pos(), etc.) or we do manual 
conversions all over the place.  (The manual conversion is just adding 
on a small offset value.  But it has to be done in lots of places.)

jason