[Freeciv-Dev] Re: (PR#8870) moving some code in adjust_map().

["Marcelo Burda" <mburda@xxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8870 >

Le lun 31/05/2004 à 08:20, Jason Short a écrit :
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8870 >
> 
> > [jdorje - Mon May 31 06:14:50 2004]:
> 
> > - Why do you move the initialization of "tres"?
> 
> Never mind, this is because maxval is a global variable (which we should
> fix later).
hmm we can change adjust_map to normalize map, were all values are are
in a range 0 .. MAX_HEIGHT_MAP, or simply 0 .. 1000

> 
> However there is a bug in your patch: you assume that all height values
> are non-negative.  This is not the case in gen5.  The fix is probably to
> use the same method as gen5 to get the initial minval and maxval values.
> 
method of gen5 is symply best
> jason
-- 
 . /  .     '    ,    .      (*)   '        `     '      `    .    
  |    ,  |   `     ,     .      ,   '  Marcelo Julián Burda      .
 /  '     \     `     \@_     '      .        '      `        '    
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~