Complete.Org: Mailing Lists: Archives: freeciv-dev: May 2004:
[Freeciv-Dev] (PR#8870) moving some code in adjust_map().
Home

[Freeciv-Dev] (PR#8870) moving some code in adjust_map().

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: mburda@xxxxxxxxx
Subject: [Freeciv-Dev] (PR#8870) moving some code in adjust_map().
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 30 May 2004 23:20:57 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8870 >

> [jdorje - Mon May 31 06:14:50 2004]:

> - Why do you move the initialization of "tres"?

Never mind, this is because maxval is a global variable (which we should
fix later).

However there is a bug in your patch: you assume that all height values
are non-negative.  This is not the case in gen5.  The fix is probably to
use the same method as gen5 to get the initial minval and maxval values.

jason



[Prev in Thread] Current Thread [Next in Thread]