[Freeciv-Dev] (PR#8845) remove begin_player_turn

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8845 >

This patch removes begin_player_turn and begin_cities_turn.

Both are currently empty (except for each other).  And they're likely to 
remain so.

See also PR#725.

jason

? convert.sh
? ferries
? flags
? output
? client/output
? data/flags
Index: server/cityturn.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/server/cityturn.c,v
retrieving revision 1.246
diff -u -r1.246 cityturn.c
--- server/cityturn.c   21 Apr 2004 18:28:28 -0000      1.246
+++ server/cityturn.c   26 May 2004 20:04:58 -0000
@@ -347,14 +347,6 @@
 /**************************************************************************
 ...
 **************************************************************************/
-void begin_cities_turn(struct player *pplayer)
-{
-  /* Nothing (deprecated)... */
-}
-
-/**************************************************************************
-...
-**************************************************************************/
 void update_city_activities(struct player *pplayer)
 {
   int gold;
Index: server/cityturn.h
===================================================================
RCS file: /home/freeciv/CVS/freeciv/server/cityturn.h,v
retrieving revision 1.33
diff -u -r1.33 cityturn.h
--- server/cityturn.h   13 Oct 2003 01:33:31 -0000      1.33
+++ server/cityturn.h   26 May 2004 20:04:58 -0000
@@ -29,7 +29,6 @@
 bool city_reduce_size(struct city *pcity, int pop_loss);
 void send_global_city_turn_notifications(struct conn_list *dest);
 void send_city_turn_notifications(struct conn_list *dest, struct city *pcity);
-void begin_cities_turn(struct player *pplayer);
 void update_city_activities(struct player *pplayer);
 int city_incite_cost(struct player *pplayer, struct city *pcity);
 void remove_obsolete_buildings_city(struct city *pcity, bool refresh);
Index: server/plrhand.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/server/plrhand.c,v
retrieving revision 1.310
diff -u -r1.310 plrhand.c
--- server/plrhand.c    11 May 2004 17:59:34 -0000      1.310
+++ server/plrhand.c    26 May 2004 20:04:58 -0000
@@ -167,14 +167,6 @@
   }
 }
 
-/**************************************************************************
-Turn info update loop, for each player at beginning of turn.
-**************************************************************************/
-void begin_player_turn(struct player *pplayer)
-{
-  begin_cities_turn(pplayer);
-}
-
 /****************************************************************************
   Check all players to see if they are dying.  Kill them if so.
 
Index: server/plrhand.h
===================================================================
RCS file: /home/freeciv/CVS/freeciv/server/plrhand.h,v
retrieving revision 1.63
diff -u -r1.63 plrhand.h
--- server/plrhand.h    10 Apr 2004 03:47:50 -0000      1.63
+++ server/plrhand.h    26 May 2004 20:04:58 -0000
@@ -31,7 +31,6 @@
 void server_player_init(struct player *pplayer, bool initmap);
 void server_remove_player(struct player *pplayer);
 void kill_player(struct player *pplayer);
-void begin_player_turn(struct player *pplayer);
 void kill_dying_players(void);
 void update_revolution(struct player *pplayer);
 void great_library(struct player *pplayer);
Index: server/srv_main.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/server/srv_main.c,v
retrieving revision 1.161
diff -u -r1.161 srv_main.c
--- server/srv_main.c   25 May 2004 00:33:16 -0000      1.161
+++ server/srv_main.c   26 May 2004 20:04:59 -0000
@@ -461,7 +461,6 @@
   players_iterate(pplayer) {
     freelog(LOG_DEBUG, "beginning player turn for #%d (%s)",
            pplayer->player_no, pplayer->name);
-    begin_player_turn(pplayer);
     /* human players also need this for building advice */
     ai_data_turn_init(pplayer);
   } players_iterate_end;