[Freeciv-Dev] (PR#8831) unnecessary invisibility check in do_move_unit?

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8831 >

In do_move_unit is the following code:

   square_iterate(punit->x, punit->y, 2, x, y) {
     bool refresh = FALSE;
     unit_list_iterate(map_get_tile(x, y)->units, pu) {
       if (unit_flag(pu, F_PARTIAL_INVIS)) {
        refresh = TRUE;
        goto out;
       }
     } unit_list_iterate_end;
   out:
     if (refresh) {
       refresh_tile_mapcanvas(x, y, FALSE);
     }
   } square_iterate_end;

which seems like it's obviously intended to reveal invisible units when 
we get next to them.  Except that the radius is 2 instead of 1.  And 
that we should always draw partially invisible units, if we know about them.

So this code should be removed right?  Greg?

-jason